Musig2: Update to 1.0.0.rc2 #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3373590167Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sputn1ck
force-pushed
the
musig2_update
branch
from
264452c to
baa44c2
Compare
sputn1ck
force-pushed
the
musig2_update
branch
from
baa44c2 to
bbe104d
Compare
sputn1ck
changed the title
|
jonasnick/bips#74 is now merged, no new changes to the reference code have been made since my last commits cc @Roasbeef |
This commit adds the pk option to NonceGen and makes it mandatory. Reference: jonasnick/bips@a89f857
This commit adds the public key to the sec nonce and ensures that we're signing with the right key. Reference: jonasnick/bips#74
This commit adds a check that the public key of the private key that is passed to the Sign function is included in the slice of public keys. Reference jonasnick/bips@ea47d52
sputn1ck
force-pushed
the
musig2_update
branch
from
bbe104d to
d99a169
Compare
guggero
approved these changes
Nov 8, 2022
| 0, | ||
| 1 | ||
| ], | ||
| "key_indices": [ |
There was a problem hiding this comment.
nit: avoid these formatting changes (probably done by the IDE) to keep the diff smaller?
|
|
||
| // ErrPubkeyInvalid is returned when the pubkey of the WithPublicKey | ||
| // option is not passed or of invalid length. | ||
| ErrPubkeyInvalid = errors.New("nonce generation requires a valid pubkey") |
There was a problem hiding this comment.
nit: use PubKey capitalization in name?
| @@ -142,6 +151,14 @@ func WithCustomRand(r io.Reader) NonceGenOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithPublicKey is the mandatory public key that will be mixed into the nonce | |||
There was a problem hiding this comment.
Not sure if it's obvious from the context or whether we should add "the mandatory public key that corresponds to the signer's private key" or something to that effect to the comment?
| @@ -38,6 +38,10 @@ var ( | |||
| // ErrSecretNonceZero is returned when a secret nonce is passed in a | |||
| // zero. | |||
| ErrSecretNonceZero = fmt.Errorf("secret nonce is blank") | |||
|
|
|||
| // ErrSecNoncePubkey is returned when the signing key does not match the | |||
There was a problem hiding this comment.
nit: capitalization of PubKey and missing full stop.
Roasbeef
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the changes from jonasnick/bips#74 which adresses the risk described in https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-October/021000.html .
Will leave it as draft, until the bip PR is merged.
The
bench_test.go/BenchmarkPartialVerifyare failing, however they also seem to be failing on master.